]> pilppa.com Git - linux-2.6-omap-h63xx.git/commitdiff
RDMA/cxgb3: Fix too-big reserved field zeroing in iwch_post_zb_read()
authorRoland Dreier <rolandd@cisco.com>
Sat, 1 Nov 2008 19:55:37 +0000 (12:55 -0700)
committerRoland Dreier <rolandd@cisco.com>
Sat, 1 Nov 2008 19:55:37 +0000 (12:55 -0700)
The array wqe->read.reserved has only two entries, but
iwch_post_zb_read() sets [0], [1], and [2], which is one too many.
This is harmless since it runs into the next field, rem_stag, which is
initialized correctly immediately after, but we might as well get
things right, especially since it makes the code smaller.

This was spotted by the Coverity checker (CID 2475).

Signed-off-by: Roland Dreier <rolandd@cisco.com>
Acked-by: Steve Wise <swise@opengridcomputing.com>
drivers/infiniband/hw/cxgb3/iwch_qp.c

index 3e4585c2318a1178262f88232926da5890c00331..19661b2f040630bfd5dded6a63eab3e6a6de19d6 100644 (file)
@@ -745,7 +745,6 @@ int iwch_post_zb_read(struct iwch_qp *qhp)
        wqe->read.rdmaop = T3_READ_REQ;
        wqe->read.reserved[0] = 0;
        wqe->read.reserved[1] = 0;
-       wqe->read.reserved[2] = 0;
        wqe->read.rem_stag = cpu_to_be32(1);
        wqe->read.rem_to = cpu_to_be64(1);
        wqe->read.local_stag = cpu_to_be32(1);