]> pilppa.com Git - linux-2.6-omap-h63xx.git/commitdiff
[SCSI] lpfc: use SCSI_MLQUEUE_TARGET_BUSY when catching the rport transition race
authorMike Christie <michaelc@cs.wisc.edu>
Sun, 17 Aug 2008 20:24:41 +0000 (15:24 -0500)
committerJames Bottomley <James.Bottomley@HansenPartnership.com>
Mon, 13 Oct 2008 13:28:47 +0000 (09:28 -0400)
We do want to call right back into the queuecommand during the race,
so we can just use SCSI_MLQUEUE_TARGET_BUSY.

Signed-off-by: Mike Christie <michaelc@cs.wisc.edu>
Acked-by: James Smart <James.Smart@Emulex.Com>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
drivers/scsi/lpfc/lpfc_scsi.c

index 1bcebbd3dfacf8a3588abbeece892e19f44eadd3..a22bdf9548a6d51847152034a20ce6a4a48e460a 100644 (file)
@@ -966,10 +966,9 @@ lpfc_queuecommand(struct scsi_cmnd *cmnd, void (*done) (struct scsi_cmnd *))
         * Catch race where our node has transitioned, but the
         * transport is still transitioning.
         */
-       if (!ndlp || !NLP_CHK_NODE_ACT(ndlp)) {
-               cmnd->result = ScsiResult(DID_BUS_BUSY, 0);
-               goto out_fail_command;
-       }
+       if (!ndlp || !NLP_CHK_NODE_ACT(ndlp))
+               goto out_target_busy;
+
        lpfc_cmd = lpfc_get_scsi_buf(phba);
        if (lpfc_cmd == NULL) {
                lpfc_adjust_queue_depth(phba);
@@ -1014,6 +1013,8 @@ lpfc_queuecommand(struct scsi_cmnd *cmnd, void (*done) (struct scsi_cmnd *))
        lpfc_release_scsi_buf(phba, lpfc_cmd);
  out_host_busy:
        return SCSI_MLQUEUE_HOST_BUSY;
+ out_target_busy:
+       return SCSI_MLQUEUE_TARGET_BUSY;
 
  out_fail_command:
        done(cmnd);