]> pilppa.com Git - linux-2.6-omap-h63xx.git/commitdiff
[PATCH] hostap: Fix null pointer dereference in prism2_pccard_card_present()
authorKalle Valo <Kalle.Valo@iki.fi>
Sun, 28 Aug 2005 19:46:57 +0000 (22:46 +0300)
committerJeff Garzik <jgarzik@pobox.com>
Sun, 28 Aug 2005 23:25:02 +0000 (19:25 -0400)
With my Buffalo WLI-CF-S11G PC Card kernel oopses every time in
prism2_interrupt() when I try load the hostap module. local->hw_priv is null
during the first call to prism2_interrupt(). It feels like
interrupts are enabled too early, or something.

This patch fixes the symptom, but not the cause.

Signed-off-by: Kalle Valo <Kalle.Valo@iki.fi>
Signed-off-by: Jeff Garzik <jgarzik@pobox.com>
drivers/net/wireless/hostap/hostap_cs.c

index 491cf49042c676eae2735abc890cec66fd4bbe92..e1f1eb8e484a78b8352ba4e370349a0abb0ca813 100644 (file)
@@ -212,7 +212,7 @@ static int prism2_event(event_t event, int priority,
 static int prism2_pccard_card_present(local_info_t *local)
 {
        struct hostap_cs_priv *hw_priv = local->hw_priv;
-       if (hw_priv->link != NULL &&
+       if (hw_priv != NULL && hw_priv->link != NULL &&
            ((hw_priv->link->state & (DEV_PRESENT | DEV_CONFIG)) ==
             (DEV_PRESENT | DEV_CONFIG)))
                return 1;