]> pilppa.com Git - linux-2.6-omap-h63xx.git/commitdiff
cy82c693: correct DMA modes clipping
authorBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Sat, 26 Jan 2008 19:13:00 +0000 (20:13 +0100)
committerBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Sat, 26 Jan 2008 19:13:00 +0000 (20:13 +0100)
* Mask device DMA masks by ATA_{S,M}WDMA2 in cy82c693_ide_dma_on().

* Remove clipping of DMA modes by id->tDMA in cy82c693_dma_enable():
  - id->tDMA may not be defined on newer devices
  - id->vendor6/id->tDMA word is in LE endianness
    (cy82c693 seems to be Alpha specific though)

* Bump driver version.

Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
drivers/ide/pci/cy82c693.c

index 1cd4e9cb0521d0532bc24c21c21506d348b3df9c..e7466f2bee7b7bd0103b017101a4d104f12a1243 100644 (file)
@@ -1,5 +1,5 @@
 /*
- * linux/drivers/ide/pci/cy82c693.c            Version 0.42    Oct 23, 2007
+ * linux/drivers/ide/pci/cy82c693.c            Version 0.43    Nov 7, 2007
  *
  *  Copyright (C) 1998-2000 Andreas S. Krebs (akrebs@altavista.net), Maintainer
  *  Copyright (C) 1998-2002 Andre Hedrick <andre@linux-ide.org>, Integrator
@@ -182,10 +182,7 @@ static void cy82c693_dma_enable (ide_drive_t *drive, int mode, int single)
 
        if (mode>2)     /* make sure we set a valid mode */
                mode = 2;
-                          
-       if (mode > drive->id->tDMA)  /* to be absolutly sure we have a valid mode */
-               mode = drive->id->tDMA;
-       
+
        index = (HWIF(drive)->channel==0) ? CY82_INDEX_CHANNEL0 : CY82_INDEX_CHANNEL1;
 
 #if CY82C693_DEBUG_LOGS
@@ -250,7 +247,10 @@ static int cy82c693_ide_dma_on (ide_drive_t *drive)
 
                        mmode = id->dma_mword & (id->dma_mword >> 8);
                        smode = id->dma_1word & (id->dma_1word >> 8);
-                                             
+
+                       mmode &= ATA_MWDMA2;
+                       smode &= ATA_SWDMA2;
+
                        if (mmode != 0) {
                                /* enable multi */
                                cy82c693_dma_enable(drive, (mmode >> 1), 0);