]> pilppa.com Git - uci.git/commitdiff
fix a stupid duplicate value checking bug (patch by Frédéric Moulins)
authorFelix Fietkau <nbd@openwrt.org>
Fri, 20 Jun 2008 17:22:25 +0000 (19:22 +0200)
committerFelix Fietkau <nbd@openwrt.org>
Fri, 20 Jun 2008 17:22:25 +0000 (19:22 +0200)
list.c

diff --git a/list.c b/list.c
index 67bde395abf3ca3a56b8d725bd4e95f5d74abc3d..b20ee712308ecdcc26db0caae67e264b2177e2f3 100644 (file)
--- a/list.c
+++ b/list.c
@@ -315,6 +315,7 @@ int uci_set_element_value(struct uci_context *ctx, struct uci_element **element,
        struct uci_element *e;
        struct uci_package *p;
        struct uci_section *s;
+       struct uci_option *o;
        char *section;
        char *option;
        char *str;
@@ -348,11 +349,12 @@ int uci_set_element_value(struct uci_context *ctx, struct uci_element **element,
        case UCI_TYPE_OPTION:
                UCI_ASSERT(ctx, value != NULL);
                size = sizeof(struct uci_option);
-               s = uci_to_option(e)->section;
+               o = uci_to_option(e);
+               s = o->section;
                section = s->e.name;
-               option = e->name;
+               option = o->e.name;
                /* matches the currently set value */
-               if (!strcmp(value, e->name))
+               if (!strcmp(value, o->value))
                        return 0;
                break;
        default: