]> pilppa.com Git - linux-2.6-omap-h63xx.git/commitdiff
[NETEM]: report reorder percent correctly.
authorStephen Hemminger <shemminger@linux-foundation.org>
Thu, 22 Mar 2007 19:15:45 +0000 (12:15 -0700)
committerDavid S. Miller <davem@sunset.davemloft.net>
Thu, 26 Apr 2007 05:27:20 +0000 (22:27 -0700)
If you setup netem to just delay packets; "tc qdisc ls" will report
the reordering as 100%. Well it's a lie, reorder isn't used unless
gap is set, so just set value to 0 so the output of utility
is correct.

Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sched/sch_netem.c

index 4818da5a7e6c7f269640806df926f71c6f6d87a1..791c615e3aadd9b2ba1321752096082668428d3e 100644 (file)
@@ -429,7 +429,8 @@ static int netem_change(struct Qdisc *sch, struct rtattr *opt)
        /* for compatiablity with earlier versions.
         * if gap is set, need to assume 100% probablity
         */
-       q->reorder = ~0;
+       if (q->gap)
+               q->reorder = ~0;
 
        /* Handle nested options after initial queue options.
         * Should have put all options in nested format but too late now.