]> pilppa.com Git - linux-2.6-omap-h63xx.git/commitdiff
[S390] vmcp: remove BKL
authorChristian Borntraeger <borntraeger@de.ibm.com>
Thu, 25 Dec 2008 12:38:34 +0000 (13:38 +0100)
committerMartin Schwidefsky <schwidefsky@de.ibm.com>
Thu, 25 Dec 2008 12:38:54 +0000 (13:38 +0100)
The vmcp driver uses the session->mutex for concurrent access of the data
structures. Therefore, the BKL in vmcp_open does not protect against any
other function in the driver.
The BLK in vmcp_open would protect concurrent access to the module init
but all necessary steps ave finished before misc_register is called.
We can safely remove the lock_kernel from vcmp.

Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
drivers/s390/char/vmcp.c

index 09e7d9bf438b0e18b1dc5d49acd9f540000dfb06..d7083b33b0fe7ce5cae31b79db117807da91d267 100644 (file)
@@ -16,7 +16,6 @@
 #include <linux/kernel.h>
 #include <linux/miscdevice.h>
 #include <linux/module.h>
-#include <linux/smp_lock.h>
 #include <asm/cpcmd.h>
 #include <asm/debug.h>
 #include <asm/uaccess.h>
@@ -41,13 +40,11 @@ static int vmcp_open(struct inode *inode, struct file *file)
        if (!session)
                return -ENOMEM;
 
-       lock_kernel();
        session->bufsize = PAGE_SIZE;
        session->response = NULL;
        session->resp_size = 0;
        mutex_init(&session->mutex);
        file->private_data = session;
-       unlock_kernel();
        return nonseekable_open(inode, file);
 }