]> pilppa.com Git - linux-2.6-omap-h63xx.git/commitdiff
IB/mthca: Fix check of size in SRQ creation
authorJack Morgenstein <jackm@mellanox.co.il>
Sun, 26 Mar 2006 15:01:12 +0000 (17:01 +0200)
committerRoland Dreier <rolandd@cisco.com>
Wed, 29 Mar 2006 17:36:46 +0000 (09:36 -0800)
The previous patch for Tavor broke MemFree logic.

The driver should perform limit check only for Tavor.  For MemFree,
the check is incorrect, since ds (WQE stride) is always a power-of-2
(although the max_desc_size may not be).

In Tavor, however, WQE stride and desc_size are the same, and are not
necessarily power-of-2.  The check was really for the WQE stride (and
it Tavor, we use max_desc_size for the stride).

Signed-off-by: Jack Morgenstein <jackm@mellanox.co.il>
Signed-off-by: Roland Dreier <rolandd@cisco.com>
drivers/infiniband/hw/mthca/mthca_srq.c

index 0cfd158022179e23804b7c6b0d8a691e495c8d38..e74751ef913cca5eebcfc955c9f3da9c242d796c 100644 (file)
@@ -206,7 +206,7 @@ int mthca_alloc_srq(struct mthca_dev *dev, struct mthca_pd *pd,
                 roundup_pow_of_two(sizeof (struct mthca_next_seg) +
                                    srq->max_gs * sizeof (struct mthca_data_seg)));
 
-       if (ds > dev->limits.max_desc_sz)
+       if (!mthca_is_memfree(dev) && (ds > dev->limits.max_desc_sz))
                return -EINVAL;
 
        srq->wqe_shift = long_log2(ds);