]> pilppa.com Git - linux-2.6-omap-h63xx.git/commitdiff
USB: fix gregkh-usb-usb-sisusb2vga-convert-printk-to-dev_-macros
authorAndrew Morton <akpm@linux-foundation.org>
Tue, 2 Oct 2007 21:40:46 +0000 (14:40 -0700)
committerGreg Kroah-Hartman <gregkh@suse.de>
Fri, 12 Oct 2007 21:55:29 +0000 (14:55 -0700)
drivers/usb/misc/sisusbvga/sisusb.c: In function 'sisusb_open':
drivers/usb/misc/sisusbvga/sisusb.c:2444: warning: 'sisusb' is used uninitialized in this function

I can tell that'll oops just by looking at it.

How come this code assume a 7,000 column xterm? :(

Cc: Felipe Balbi <felipe.lima@indt.org.br>
Cc: Thomas <thomas@winischhofer.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/usb/misc/sisusbvga/sisusb.c

index 033bdfe9b215e27685fe59fa551d0e6313dee7e5..0790829a5701b85a5664bcbc8fc8161cca961061 100644 (file)
@@ -3323,15 +3323,7 @@ static int __init usb_sisusb_init(void)
        sisusb_init_concode();
 #endif
 
-       if (!(retval = usb_register(&sisusb_driver))) {
-
-               dev_info(&sisusb->sisusb_dev->dev, "Driver version %d.%d.%d\n", SISUSB_VERSION,
-                               SISUSB_REVISION, SISUSB_PATCHLEVEL);
-               dev_info(&sisusb->sisusb_dev->dev, "sisusb: Copyright (C) 2005 Thomas Winischhofer\n");
-
-       }
-
-       return retval;
+       return usb_register(&sisusb_driver);
 }
 
 static void __exit usb_sisusb_exit(void)