]> pilppa.com Git - linux-2.6-omap-h63xx.git/commitdiff
[NETFILTER]: nfnetlink_log: micro-optimization: don't modify destroyed instance
authorMichal Miroslaw <mirq-linux@rere.qmqm.pl>
Fri, 23 Mar 2007 18:11:48 +0000 (11:11 -0700)
committerDavid S. Miller <davem@sunset.davemloft.net>
Thu, 26 Apr 2007 05:27:39 +0000 (22:27 -0700)
Simple micro-optimization: Don't change any options if the instance is
being destroyed.

Signed-off-by: Michal Miroslaw <mirq-linux@rere.qmqm.pl>
Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/netfilter/nfnetlink_log.c

index d4b45e28ebde12a5085fc232ab5e0b3130ea979a..441f0fbcfb26c850a9334788ef33d3f12f0b1e75 100644 (file)
@@ -825,7 +825,7 @@ nfulnl_recv_config(struct sock *ctnl, struct sk_buff *skb,
                        }
 
                        instance_destroy(inst);
-                       break;
+                       goto out;
                case NFULNL_CFG_CMD_PF_BIND:
                        UDEBUG("registering log handler for pf=%u\n", pf);
                        ret = nf_log_register(pf, &nfulnl_logger);