]> pilppa.com Git - linux-2.6-omap-h63xx.git/commitdiff
bnx2x: Removing the PMF indication when unloading
authorEilon Greenstein <eilong@broadcom.com>
Tue, 4 Nov 2008 00:45:55 +0000 (16:45 -0800)
committerDavid S. Miller <davem@davemloft.net>
Tue, 4 Nov 2008 00:45:55 +0000 (16:45 -0800)
When the PMF flag is set, the driver can access the HW freely. When the
driver is unloaded, it should not access the HW. The problem caused fatal
errors when "ethtool -i" was called after the calling instance was unloaded
and another instance was already loaded

Signed-off-by: Eilon Greenstein <eilong@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/bnx2x_main.c

index fce745148ff9a9896640be5e4c4fa780d3fc6b72..61152e149e676ad6c917ec0e36a8be90e6c9a663 100644 (file)
@@ -6481,6 +6481,7 @@ load_int_disable:
        bnx2x_free_irq(bp);
 load_error:
        bnx2x_free_mem(bp);
+       bp->port.pmf = 0;
 
        /* TBD we really need to reset the chip
           if we want to recover from this */
@@ -6791,6 +6792,7 @@ unload_error:
        /* Report UNLOAD_DONE to MCP */
        if (!BP_NOMCP(bp))
                bnx2x_fw_command(bp, DRV_MSG_CODE_UNLOAD_DONE);
+       bp->port.pmf = 0;
 
        /* Free SKBs, SGEs, TPA pool and driver internals */
        bnx2x_free_skbs(bp);