]> pilppa.com Git - linux-2.6-omap-h63xx.git/commitdiff
[PATCH] Don't check pointer for NULL before passing it to kfree [arch/powerpc/kernel...
authorJesper Juhl <jesper.juhl@gmail.com>
Sat, 4 Feb 2006 19:35:59 +0000 (20:35 +0100)
committerPaul Mackerras <paulus@samba.org>
Tue, 7 Feb 2006 10:51:53 +0000 (21:51 +1100)
Checking a pointer for NULL before passing it to kfree is pointless, kfree
does its own NULL checking of input.

Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
Signed-off-by: Paul Mackerras <paulus@samba.org>
arch/powerpc/kernel/rtas_flash.c

index 50500093c97f686995039f6826b9569f535a3506..aaf384c3f04a62eca2bbe497bdfd0b80e905b265 100644 (file)
@@ -672,8 +672,7 @@ static void rtas_flash_firmware(int reboot_type)
 static void remove_flash_pde(struct proc_dir_entry *dp)
 {
        if (dp) {
-               if (dp->data != NULL)
-                       kfree(dp->data);
+               kfree(dp->data);
                dp->owner = NULL;
                remove_proc_entry(dp->name, dp->parent);
        }