]> pilppa.com Git - linux-2.6-omap-h63xx.git/commitdiff
V4L/DVB (4289): Missing statement in drivers/media/dvb/frontends/cx22700.c
authorEric Sesterhenn <snakebyte@gmx.de>
Fri, 30 Jun 2006 14:51:11 +0000 (11:51 -0300)
committerMauro Carvalho Chehab <mchehab@infradead.org>
Fri, 30 Jun 2006 18:59:51 +0000 (15:59 -0300)
Stumbled over this because of coverity (id #492),
seems like we are missing a return statement here and fail
to do proper bounds checking. If this assumption is false
we should at least change the identation to make it clear

Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
drivers/media/dvb/frontends/cx22700.c

index 3c7c09a362b2ac88bf517ae1e2499fa347f97f82..13ad1bfae663f0c0386960d7314b7c65d4ff6ca7 100644 (file)
@@ -134,6 +134,7 @@ static int cx22700_set_tps (struct cx22700_state *state, struct dvb_ofdm_paramet
                return -EINVAL;
 
        if (p->code_rate_LP < FEC_1_2 || p->code_rate_LP > FEC_7_8)
+               return -EINVAL;
 
        if (p->code_rate_HP == FEC_4_5 || p->code_rate_LP == FEC_4_5)
                return -EINVAL;