]> pilppa.com Git - linux-2.6-omap-h63xx.git/commitdiff
[CPUFREQ] powernow-k8.c: fix a check-after-use
authorAdrian Bunk <bunk@stusta.de>
Tue, 18 Apr 2006 22:07:28 +0000 (00:07 +0200)
committerDave Jones <davej@redhat.com>
Tue, 18 Apr 2006 22:24:52 +0000 (17:24 -0500)
This patch fixes a check-after-use introduced by commit
4211a30349e8d2b724cfb4ce2584604f5e59c299 and spotted by the Coverity checker.

Signed-off-by: Adrian Bunk <bunk@stusta.de>
Signed-off-by: Dave Jones <davej@redhat.com>
arch/i386/kernel/cpu/cpufreq/powernow-k8.c

index 30bb6fd5b2b268762faea09b5b9969e0fda47c44..71fffa17442530949dccf45aa210c2e371188a59 100644 (file)
@@ -905,14 +905,17 @@ static int powernowk8_target(struct cpufreq_policy *pol, unsigned targfreq, unsi
 {
        cpumask_t oldmask = CPU_MASK_ALL;
        struct powernow_k8_data *data = powernow_data[pol->cpu];
-       u32 checkfid = data->currfid;
-       u32 checkvid = data->currvid;
+       u32 checkfid;
+       u32 checkvid;
        unsigned int newstate;
        int ret = -EIO;
 
        if (!data)
                return -EINVAL;
 
+       checkfid = data->currfid;
+       checkvid = data->currvid;
+
        /* only run on specific CPU from here on */
        oldmask = current->cpus_allowed;
        set_cpus_allowed(current, cpumask_of_cpu(pol->cpu));