]> pilppa.com Git - linux-2.6-omap-h63xx.git/commitdiff
agp: fix SIS 5591/5592 wrong PCI id
authorKrzysztof Helt <krzysztof.h1@wp.pl>
Wed, 6 Aug 2008 16:48:45 +0000 (18:48 +0200)
committerDave Airlie <airlied@redhat.com>
Tue, 12 Aug 2008 00:13:38 +0000 (10:13 +1000)
The correct id is the id of the main host (5591) not
the id of the PCI-to-PCI bridge AGP (0001).
Output from "lspci -nv" shows that only the former
has AGP capabilities flag set:

00:00.0 0600: 1039:5591 (rev 02)
        Flags: bus master, medium devsel, latency 64
        Memory at ec000000 (32-bit, non-prefetchable) [size=32M]
        Capabilities: [c0] AGP version 1.0

00:02.0 0604: 1039:0001 (prog-if 00 [Normal decode])
        Flags: bus master, fast devsel, latency 0
        Bus: primary=00, secondary=01, subordinate=01, sec-latency=0
        I/O behind bridge: 0000c000-0000cfff
        Memory behind bridge: eb500000-eb5fffff
        Prefetchable memory behind bridge: eb300000-eb3fffff

Signed-off-by: Krzysztof Helt <krzysztof.h1@wp.pl>
Signed-off-by: Dave Airlie <airlied@redhat.com>
drivers/char/agp/sis-agp.c

index 52c2db675e50493e1c575c068716ea335a08688d..2587ef96a9603afdd965ce016be1806eab000a70 100644 (file)
@@ -241,7 +241,7 @@ static struct pci_device_id agp_sis_pci_table[] = {
                .class          = (PCI_CLASS_BRIDGE_HOST << 8),
                .class_mask     = ~0,
                .vendor         = PCI_VENDOR_ID_SI,
-               .device         = PCI_DEVICE_ID_SI_5591_AGP,
+               .device         = PCI_DEVICE_ID_SI_5591,
                .subvendor      = PCI_ANY_ID,
                .subdevice      = PCI_ANY_ID,
        },