]> pilppa.com Git - linux-2.6-omap-h63xx.git/commitdiff
MMC: OMAP: Do not busy wait for end of command for ever
authorJarkko Lavinen <jarkko.lavinen@nokia.com>
Fri, 28 Dec 2007 20:38:23 +0000 (16:38 -0400)
committerTony Lindgren <tony@atomide.com>
Thu, 24 Jan 2008 19:01:03 +0000 (11:01 -0800)
The limit was a fixed 100k limit in the busy loop, which is not
accurate. It would better to have time limit for the worst case
which occurs when sending 80 cycles at 400 kHz and takes about
200 microseconds, so limit the max time spend in the busy loop
for some 250 microseconds.

Signed-off-by: Jarkko Lavinen <jarkko.lavinen@nokia.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
drivers/mmc/host/omap.c

index 47150a2716ce331a3c012a907e12fde39c14e271..60e3fd703952fa7d20073a5fd82d1138563cd7b7 100644 (file)
@@ -1294,11 +1294,17 @@ static void mmc_omap_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)
                OMAP_MMC_WRITE(host, CON, dsor);
        slot->saved_con = dsor;
        if (ios->power_mode == MMC_POWER_ON) {
+               /* worst case at 400kHz, 80 cycles makes 200 microsecs */
+               int usecs = 250;
+
                /* Send clock cycles, poll completion */
                OMAP_MMC_WRITE(host, IE, 0);
                OMAP_MMC_WRITE(host, STAT, 0xffff);
                OMAP_MMC_WRITE(host, CMD, 1 << 7);
-               while ((OMAP_MMC_READ(host, STAT) & 1) == 0);
+               while (usecs > 0 && (OMAP_MMC_READ(host, STAT) & 1) == 0) {
+                       udelay(1);
+                       usecs--;
+               }
                OMAP_MMC_WRITE(host, STAT, 1);
        }