]> pilppa.com Git - linux-2.6-omap-h63xx.git/commitdiff
rio: typo in bitwise AND expression.
authorWilly Tarreau <w@1wt.eu>
Sat, 17 Feb 2007 17:57:09 +0000 (18:57 +0100)
committerAdrian Bunk <bunk@stusta.de>
Sat, 17 Feb 2007 17:57:09 +0000 (18:57 +0100)
The line :

    hp->Mode &= !RIO_PCI_INT_ENABLE;

is obviously wrong as RIO_PCI_INT_ENABLE=0x04 and is used as a bitmask
2 lines before. Getting no IRQ would not disable RIO_PCI_INT_ENABLE
but rather RIO_PCI_BOOT_FROM_RAM which equals 0x01.

Obvious fix is to change ! for ~.

Signed-off-by: Willy Tarreau <w@1wt.eu>
Signed-off-by: Adrian Bunk <bunk@stusta.de>
drivers/char/rio/rio_linux.c

index 85c1618452605819fa2110f9a68cb208dc46df84..294e9cb0c449424cdb47761712cf2db51b7fb259 100644 (file)
@@ -1146,7 +1146,7 @@ static int __init rio_init(void)
                                rio_dprintk(RIO_DEBUG_INIT, "Enabling interrupts on rio card.\n");
                                hp->Mode |= RIO_PCI_INT_ENABLE;
                        } else
-                               hp->Mode &= !RIO_PCI_INT_ENABLE;
+                               hp->Mode &= ~RIO_PCI_INT_ENABLE;
                        rio_dprintk(RIO_DEBUG_INIT, "New Mode: %x\n", hp->Mode);
                        rio_start_card_running(hp);
                }