]> pilppa.com Git - linux-2.6-omap-h63xx.git/commitdiff
ARM: OMAP3: mmc-twl4030 fix name buffer length, v2
authorAdrian Hunter <adrian.hunter@nokia.com>
Tue, 24 Mar 2009 01:23:46 +0000 (18:23 -0700)
committerTony Lindgren <tony@atomide.com>
Tue, 24 Mar 2009 01:51:22 +0000 (18:51 -0700)
Add 1 to buffer length for null terminator and use snprintf.

Signed-off-by: Adrian Hunter <adrian.hunter@nokia.com>
Acked-by: David Brownell <dbrownell@users.sourceforge.net>
Signed-off-by: Tony Lindgren <tony@atomide.com>
arch/arm/mach-omap2/mmc-twl4030.c

index 437f52073f6ef3f6d4ad93f36c417315fb0ded7e..84cac87537a3ec8aa20ed1c264e910e3bd27cf94 100644 (file)
@@ -59,7 +59,7 @@ static struct twl_mmc_controller {
        struct omap_mmc_platform_data   *mmc;
        u8              twl_vmmc_dev_grp;
        u8              twl_mmc_dedicated;
-       char            name[HSMMC_NAME_LEN];
+       char            name[HSMMC_NAME_LEN + 1];
 } hsmmc[] = {
        {
                .twl_vmmc_dev_grp               = VMMC1_DEV_GRP,
@@ -349,7 +349,8 @@ void __init twl4030_mmc_init(struct twl4030_hsmmc_info *controllers)
                        return;
                }
 
-               sprintf(twl->name, "mmc%islot%i", c->mmc, 1);
+               snprintf(twl->name, ARRAY_SIZE(twl->name), "mmc%islot%i",
+                               c->mmc, 1);
                mmc->slots[0].name = twl->name;
                mmc->nr_slots = 1;
                mmc->slots[0].ocr_mask = MMC_VDD_165_195 |