]> pilppa.com Git - linux-2.6-omap-h63xx.git/commitdiff
x86: mtrr_cleanup try gran_size to less than 1M, v3
authorYinghai Lu <yinghai@kernel.org>
Thu, 2 Oct 2008 22:46:20 +0000 (15:46 -0700)
committerIngo Molnar <mingo@elte.hu>
Fri, 3 Oct 2008 07:41:55 +0000 (09:41 +0200)
J.A. Magallón reported:

 >> Also, on a 64 bit box with 4Gb, it gives this:
 >>
 >> cicely:~# cat /proc/mtrr
 >> reg00: base=0x00000000 (   0MB), size=4096MB: write-back, count=1
 >> reg01: base=0x100000000 (4096MB), size=1024MB: write-back, count=1
 >> reg02: base=0x140000000 (5120MB), size= 512MB: write-back, count=1
 >> reg03: base=0x160000000 (5632MB), size= 256MB: write-back, count=1
 >> reg04: base=0x80000000 (2048MB), size=2048MB: uncachable, count=1

boundary handling has a problem ... fix it.

Reported-by: J.A. Magallón <jamagallon@ono.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
arch/x86/kernel/cpu/mtrr/main.c

index 8f1a342b16b745c2088cfe9bce092f565a572ca1..b4a3f0c1a5e369b544c459c978015895768ddbf3 100644 (file)
@@ -1044,7 +1044,7 @@ second_try:
                hole_sizek = range0_sizek - state->range_sizek - second_sizek;
 
                /* hole size should be less than half of range0 size */
-               if (hole_sizek > (range0_sizek >> 1) &&
+               if (hole_sizek >= (range0_sizek >> 1) &&
                    range0_sizek >= chunk_sizek) {
                        range0_sizek -= chunk_sizek;
                        second_sizek = 0;