]> pilppa.com Git - linux-2.6-omap-h63xx.git/commitdiff
ALSA: move snd_powermac's probe function to .devinit.text
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Fri, 27 Mar 2009 23:27:10 +0000 (00:27 +0100)
committerTakashi Iwai <tiwai@suse.de>
Mon, 6 Apr 2009 01:52:57 +0000 (03:52 +0200)
A pointer to snd_pmac_probe is passed to the core via
platform_driver_register and so the function must not disappear when the
.init sections are discarded.  Otherwise (when having HOTPLUG=y)
unbinding and binding a device to the driver via sysfs will result in an
oops as does a device being registered late.

An alternative to this patch is using platform_driver_probe instead of
platform_driver_register plus removing the pointer to the probe function
from the struct platform_driver.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Cc: Jaroslav Kysela <perex@perex.cz>
Cc: Johannes Berg <johannes@sipsolutions.net>
Cc: Rene Herman <rene.herman@keyaccess.nl>
Cc: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/ppc/powermac.c

index 5a929069dce980453a67d526450b9cf877fb9d09..a2b69b8cff43f73d48674f894e1bd74884d68a7b 100644 (file)
@@ -51,7 +51,7 @@ static struct platform_device *device;
 /*
  */
 
-static int __init snd_pmac_probe(struct platform_device *devptr)
+static int __devinit snd_pmac_probe(struct platform_device *devptr)
 {
        struct snd_card *card;
        struct snd_pmac *chip;