]> pilppa.com Git - linux-2.6-omap-h63xx.git/commitdiff
tulip: Fix dead 21041 ethernet after ifconfig down
authorThomas Bogendoerfer <tsbogend@alpha.franken.de>
Sat, 13 Sep 2008 19:06:42 +0000 (15:06 -0400)
committerJeff Garzik <jgarzik@redhat.com>
Wed, 24 Sep 2008 22:48:52 +0000 (18:48 -0400)
The de2104x did a pci_disable_device() in it's close function, but
the open function never does a pci_enable_device() and assumes that
the device is already enabled. Considering that downing the interface
is just a temporary thing the pci_disable_device() isn't a pretty good
idea and removing it from the close function just fixes the bug.

Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Acked-by: Grant Grundler <grundler@parisc-linux.org>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
drivers/net/tulip/de2104x.c

index 9281d06d5aaab071163b7c53ff14087b8db66436..f54c45049d50d86c700e3f18a5c2525321a662c9 100644 (file)
@@ -1418,7 +1418,6 @@ static int de_close (struct net_device *dev)
 
        de_free_rings(de);
        de_adapter_sleep(de);
-       pci_disable_device(de->pdev);
        return 0;
 }