]> pilppa.com Git - linux-2.6-omap-h63xx.git/commitdiff
[SCSI] aacraid: bad BUG_ON fix
authorMark Haverkamp <markh@osdl.org>
Thu, 1 Sep 2005 15:19:23 +0000 (08:19 -0700)
committerJames Bottomley <jejb@mulgrave.(none)>
Mon, 5 Sep 2005 00:46:06 +0000 (19:46 -0500)
This was noticed by Doug Bazamic and the fix found by Mark Salyzyn at
Adaptec.

There was an error in the BUG_ON() statement that validated the
calculated fib size which can cause the driver to panic.

Signed-off-by: Mark Haverkamp <markh@osdl.org>
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
drivers/scsi/aacraid/aachba.c

index 83bfab73ff65cd2deb2205ae75f7d3c067562e8f..a8e3dfcd0dc758025a388a201f8eaddae5d23d58 100644 (file)
@@ -972,7 +972,7 @@ static int aac_read(struct scsi_cmnd * scsicmd, int cid)
                fibsize = sizeof(struct aac_read64) + 
                        ((le32_to_cpu(readcmd->sg.count) - 1) * 
                         sizeof (struct sgentry64));
-               BUG_ON (fibsize > (sizeof(struct hw_fib) - 
+               BUG_ON (fibsize > (dev->max_fib_size - 
                                        sizeof(struct aac_fibhdr)));
                /*
                 *      Now send the Fib to the adapter