]> pilppa.com Git - linux-2.6-omap-h63xx.git/commitdiff
sdhci: 'scratch' may be used uninitialized
authorSteven Noonan <steven@uplinklabs.net>
Wed, 1 Oct 2008 08:50:25 +0000 (01:50 -0700)
committerPierre Ossman <drzeus@drzeus.cx>
Sun, 12 Oct 2008 09:04:36 +0000 (11:04 +0200)
The variable 'scratch' is always initialized before it's used. The
conditional which is responsible for initialization of 'scratch' will
always evaluate 'true' when the first loop iteration occurs, and thus,
it's properly initialized. GCC doesn't see this, of course, so using
the uninitialized_var() macro seems to work for silencing this case.

Signed-off-by: Steven Noonan <steven@uplinklabs.net>
Signed-off-by: Pierre Ossman <drzeus@drzeus.cx>
drivers/mmc/host/sdhci.c

index 3c808d22f9d59b78e0d7d86299a69acf3129eff1..30f64b1f2354af215cfb1dc377b115637902cd23 100644 (file)
@@ -177,7 +177,7 @@ static void sdhci_read_block_pio(struct sdhci_host *host)
 {
        unsigned long flags;
        size_t blksize, len, chunk;
-       u32 scratch;
+       u32 uninitialized_var(scratch);
        u8 *buf;
 
        DBG("PIO reading\n");