]> pilppa.com Git - linux-2.6-omap-h63xx.git/commitdiff
virtio_net: remove overzealous printk
authorAnthony Liguori <aliguori@us.ibm.com>
Mon, 7 Apr 2008 20:33:16 +0000 (15:33 -0500)
committerLinus Torvalds <torvalds@linux-foundation.org>
Mon, 7 Apr 2008 20:56:33 +0000 (13:56 -0700)
The 'disable_cb' is really just a hint and as such, it's possible for more
work to get queued up while callbacks are disabled.  Under stress with an
SMP guest, this printk triggers very frequently.  There is no race here, this
is how things are designed to work so let's just remove the printk.

Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
Acked-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/net/virtio_net.c

index b58472cf76f862c16fa861b02bcb494008c00f90..d1a200ff5fd266c05e9a876e5e4e550737f77d84 100644 (file)
@@ -284,7 +284,6 @@ again:
                /* Activate callback for using skbs: if this returns false it
                 * means some were used in the meantime. */
                if (unlikely(!vi->svq->vq_ops->enable_cb(vi->svq))) {
-                       printk("Unlikely: restart svq race\n");
                        vi->svq->vq_ops->disable_cb(vi->svq);
                        netif_start_queue(dev);
                        goto again;