]> pilppa.com Git - linux-2.6-omap-h63xx.git/commitdiff
V4L/DVB (8789): wm8739: remove wrong kfree
authorHans Verkuil <hverkuil@xs4all.nl>
Sun, 24 Aug 2008 09:29:30 +0000 (06:29 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Thu, 11 Sep 2008 02:18:32 +0000 (23:18 -0300)
i2c_client is allocated for us, we should never free it ourselves.

Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/video/wm8739.c

index 95c79ad804872b0f0df78bea3ecb4283174a06bd..54ac3fe26ec2ad4afe2371ae069caa25f9aa1597 100644 (file)
@@ -274,10 +274,8 @@ static int wm8739_probe(struct i2c_client *client,
                        client->addr << 1, client->adapter->name);
 
        state = kmalloc(sizeof(struct wm8739_state), GFP_KERNEL);
-       if (state == NULL) {
-               kfree(client);
+       if (state == NULL)
                return -ENOMEM;
-       }
        state->vol_l = 0x17; /* 0dB */
        state->vol_r = 0x17; /* 0dB */
        state->muted = 0;