]> pilppa.com Git - linux-2.6-omap-h63xx.git/commitdiff
[IPV6]: Fix source address selection.
authorJiri Kosina <jkosina@suse.cz>
Sun, 16 Sep 2007 21:48:21 +0000 (14:48 -0700)
committerDavid S. Miller <davem@davemloft.net>
Sun, 16 Sep 2007 21:48:21 +0000 (14:48 -0700)
The commit 95c385 broke proper source address selection for cases in which
there is a address which is makred 'deprecated'. The commit mistakenly
changed ifa->flags to ifa_result->flags (probably copy/paste error from a
few lines above) in the 'Rule 3' address selection code.

The patch restores the previous RFC-compliant behavior.

Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv6/addrconf.c

index 91ef3be5abadeab0b778dfaba86cce6b440c3362..45b4c82148a065b43a4a3e14648032a69f00721d 100644 (file)
@@ -1021,7 +1021,7 @@ int ipv6_dev_get_saddr(struct net_device *daddr_dev,
                                hiscore.rule++;
                        }
                        if (ipv6_saddr_preferred(score.addr_type) ||
-                          (((ifa_result->flags &
+                          (((ifa->flags &
                            (IFA_F_DEPRECATED|IFA_F_OPTIMISTIC)) == 0))) {
                                score.attrs |= IPV6_SADDR_SCORE_PREFERRED;
                                if (!(hiscore.attrs & IPV6_SADDR_SCORE_PREFERRED)) {