]> pilppa.com Git - linux-2.6-omap-h63xx.git/commitdiff
arcmsr: endianness bug
authorAl Viro <viro@ftp.linux.org.uk>
Mon, 29 Oct 2007 05:08:48 +0000 (05:08 +0000)
committerLinus Torvalds <torvalds@woody.linux-foundation.org>
Mon, 29 Oct 2007 14:41:33 +0000 (07:41 -0700)
initializing a field in data shared with the card with
cpu_to_le32(something) | 0x100000 is broken - the field is, indeed,
little-endian and we need cpu_to_le32() on both parts.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/scsi/arcmsr/arcmsr_hba.c

index aaee028dd901bc98aae204438b595d36fbcbdbef..4c1b3b4ae35be2a17a4dc8c2f3861964beeaf935 100644 (file)
@@ -916,7 +916,7 @@ static void arcmsr_build_ccb(struct AdapterControlBlock *acb,
 
                                pdma_sg->addresshigh = address_hi;
                                pdma_sg->address = address_lo;
-                               pdma_sg->length = length|IS_SG64_ADDR;
+                               pdma_sg->length = length|cpu_to_le32(IS_SG64_ADDR);
                                psge += sizeof (struct SG64ENTRY);
                                arccdbsize += sizeof (struct SG64ENTRY);
                        }