]> pilppa.com Git - linux-2.6-omap-h63xx.git/commitdiff
KVM: s390: Fix memory leak of vcpu->run
authorChristian Borntraeger <borntraeger@de.ibm.com>
Wed, 26 Nov 2008 13:51:08 +0000 (14:51 +0100)
committerAvi Kivity <avi@redhat.com>
Wed, 31 Dec 2008 14:55:03 +0000 (16:55 +0200)
The s390 backend of kvm never calls kvm_vcpu_uninit. This causes
a memory leak of vcpu->run pages.
Lets call kvm_vcpu_uninit in kvm_arch_vcpu_destroy to free
the vcpu->run.

Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
Acked-by: Carsten Otte <cotte@de.ibm.com>
Signed-off-by: Avi Kivity <avi@redhat.com>
arch/s390/kvm/kvm-s390.c

index 3db9e5d45a67a1e3bba84a0be3a445a04a438892..76f05ddaef10fbfe5a3c17d4e337f4a05e07ea78 100644 (file)
@@ -198,6 +198,7 @@ void kvm_arch_vcpu_destroy(struct kvm_vcpu *vcpu)
 {
        VCPU_EVENT(vcpu, 3, "%s", "free cpu");
        free_page((unsigned long)(vcpu->arch.sie_block));
+       kvm_vcpu_uninit(vcpu);
        kfree(vcpu);
 }
 
@@ -230,8 +231,7 @@ int kvm_arch_vcpu_init(struct kvm_vcpu *vcpu)
 
 void kvm_arch_vcpu_uninit(struct kvm_vcpu *vcpu)
 {
-       /* kvm common code refers to this, but does'nt call it */
-       BUG();
+       /* Nothing todo */
 }
 
 void kvm_arch_vcpu_load(struct kvm_vcpu *vcpu, int cpu)