ALSA: Kill snd_assert() in sound/isa/*

Kill snd_assert() in sound/isa/*, either removed or replaced with
if () with snd_BUG_ON().

Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Jaroslav Kysela <perex@perex.cz>

diff --git a/sound/isa/ad1816a/ad1816a_lib.c b/sound/isa/ad1816a/ad1816a_lib.c
index 4b8dfe2e3dcb69df0767b43df62ef2b9cf0d44a9..3bfca7c59bafe5eaa2e994f44ecc658700e15abd 100644 (file)
--- a/sound/isa/ad1816a/ad1816a_lib.c
+++ b/sound/isa/ad1816a/ad1816a_lib.c
@@ -394,7 +394,8 @@ static int snd_ad1816a_timer_open(struct snd_timer *timer)
 
 static unsigned long snd_ad1816a_timer_resolution(struct snd_timer *timer)
 {
-       snd_assert(timer != NULL, return 0);
+       if (snd_BUG_ON(!timer))
+               return 0;
 
        return 10000;
 }
@@ -961,7 +962,8 @@ int __devinit snd_ad1816a_mixer(struct snd_ad1816a *chip)
        unsigned int idx;
        int err;
 
-       snd_assert(chip != NULL && chip->card != NULL, return -EINVAL);
+       if (snd_BUG_ON(!chip || !chip->card))
+               return -EINVAL;
 
        card = chip->card;
 

diff --git a/sound/isa/cs423x/cs4236_lib.c b/sound/isa/cs423x/cs4236_lib.c
index 33e9cf178b8bcc7290d2d7d84fe505bf45c38565..6a85fdc53b60a716f248ad1c20210f1148732cd6 100644 (file)
--- a/sound/isa/cs423x/cs4236_lib.c
+++ b/sound/isa/cs423x/cs4236_lib.c
@@ -967,7 +967,8 @@ int snd_cs4236_mixer(struct snd_wss *chip)
        int err;
        struct snd_kcontrol_new *kcontrol;
 
-       snd_assert(chip != NULL && chip->card != NULL, return -EINVAL);
+       if (snd_BUG_ON(!chip || !chip->card))
+               return -EINVAL;
        card = chip->card;
        strcpy(card->mixername, snd_wss_chip_id(chip));
 

diff --git a/sound/isa/es1688/es1688_lib.c b/sound/isa/es1688/es1688_lib.c
index 1e1e575b1db329f87b289cb4cc57bbb954f1bae0..4fbb508a817f39485406800431c87fc7130c8450 100644 (file)
--- a/sound/isa/es1688/es1688_lib.c
+++ b/sound/isa/es1688/es1688_lib.c
@@ -1009,7 +1009,8 @@ int snd_es1688_mixer(struct snd_es1688 *chip)
        int err;
        unsigned char reg, val;
 
-       snd_assert(chip != NULL && chip->card != NULL, return -EINVAL);
+       if (snd_BUG_ON(!chip || !chip->card))
+               return -EINVAL;
 
        card = chip->card;
 

diff --git a/sound/isa/gus/gus_main.c b/sound/isa/gus/gus_main.c
index cccc16c8113f35a949bc775b56a04b2a4f9f2b38..12eb98f2f931e123c583419134064c1fb7004e33 100644 (file)
--- a/sound/isa/gus/gus_main.c
+++ b/sound/isa/gus/gus_main.c
@@ -276,9 +276,11 @@ static int snd_gus_init_dma_irq(struct snd_gus_card * gus, int latches)
        static unsigned char dmas[8] =
                {6, 1, 0, 2, 0, 3, 4, 5};
 
-       snd_assert(gus != NULL, return -EINVAL);
+       if (snd_BUG_ON(!gus))
+               return -EINVAL;
        card = gus->card;
-       snd_assert(card != NULL, return -EINVAL);
+       if (snd_BUG_ON(!card))
+               return -EINVAL;
 
        gus->mix_cntrl_reg &= 0xf8;
        gus->mix_cntrl_reg |= 0x01;     /* disable MIC, LINE IN, enable LINE OUT */

diff --git a/sound/isa/gus/gus_mixer.c b/sound/isa/gus/gus_mixer.c
index ebdb33469306df356c9a9303c0c8f1dc22c1b802..0dd43414016e8236a968d0af181563288f833ba5 100644 (file)
--- a/sound/isa/gus/gus_mixer.c
+++ b/sound/isa/gus/gus_mixer.c
@@ -161,9 +161,11 @@ int snd_gf1_new_mixer(struct snd_gus_card * gus)
        unsigned int idx, max;
        int err;
 
-       snd_assert(gus != NULL, return -EINVAL);
+       if (snd_BUG_ON(!gus))
+               return -EINVAL;
        card = gus->card;
-       snd_assert(card != NULL, return -EINVAL);
+       if (snd_BUG_ON(!card))
+               return -EINVAL;
 
        if (gus->ics_flag)
                snd_component_add(card, "ICS2101");

diff --git a/sound/isa/gus/gus_pcm.c b/sound/isa/gus/gus_pcm.c
index 99731dc9732564fa1223becbadff7f2e0b9cb782..38510aeb21c64893a988a900224bd7420b037ff2 100644 (file)
--- a/sound/isa/gus/gus_pcm.c
+++ b/sound/isa/gus/gus_pcm.c
@@ -352,8 +352,10 @@ static int snd_gf1_pcm_playback_copy(struct snd_pcm_substream *substream,
        
        bpos = samples_to_bytes(runtime, pos) + (voice * (pcmp->dma_size / 2));
        len = samples_to_bytes(runtime, count);
-       snd_assert(bpos <= pcmp->dma_size, return -EIO);
-       snd_assert(bpos + len <= pcmp->dma_size, return -EIO);
+       if (snd_BUG_ON(bpos > pcmp->dma_size))
+               return -EIO;
+       if (snd_BUG_ON(bpos + len > pcmp->dma_size))
+               return -EIO;
        if (copy_from_user(runtime->dma_area + bpos, src, len))
                return -EFAULT;
        if (snd_gf1_pcm_use_dma && len > 32) {
@@ -381,8 +383,10 @@ static int snd_gf1_pcm_playback_silence(struct snd_pcm_substream *substream,
        
        bpos = samples_to_bytes(runtime, pos) + (voice * (pcmp->dma_size / 2));
        len = samples_to_bytes(runtime, count);
-       snd_assert(bpos <= pcmp->dma_size, return -EIO);
-       snd_assert(bpos + len <= pcmp->dma_size, return -EIO);
+       if (snd_BUG_ON(bpos > pcmp->dma_size))
+               return -EIO;
+       if (snd_BUG_ON(bpos + len > pcmp->dma_size))
+               return -EIO;
        snd_pcm_format_set_silence(runtime->format, runtime->dma_area + bpos, count);
        if (snd_gf1_pcm_use_dma && len > 32) {
                return snd_gf1_pcm_block_change(substream, bpos, pcmp->memory + bpos, len);

diff --git a/sound/isa/opti9xx/miro.c b/sound/isa/opti9xx/miro.c
index 4641daa7844d37bed548d421b5387dd84263b29c..440755cc00137c663e39c11e258c76ca5d944bed 100644 (file)
--- a/sound/isa/opti9xx/miro.c
+++ b/sound/isa/opti9xx/miro.c
@@ -675,7 +675,8 @@ static int __devinit snd_miro_mixer(struct snd_miro *miro)
        unsigned int idx;
        int err;
 
-       snd_assert(miro != NULL && miro->card != NULL, return -EINVAL);
+       if (snd_BUG_ON(!miro || !miro->card))
+               return -EINVAL;
 
        card = miro->card;
 

diff --git a/sound/isa/sb/emu8000.c b/sound/isa/sb/emu8000.c
index b35be7d9a9fa8b4a70e1037534c2e8bd0b821d9f..96678d5d3834863fbfe440df54b8170cfa088095 100644 (file)
--- a/sound/isa/sb/emu8000.c
+++ b/sound/isa/sb/emu8000.c
@@ -1023,7 +1023,8 @@ snd_emu8000_create_mixer(struct snd_card *card, struct snd_emu8000 *emu)
 {
        int i, err = 0;
 
-       snd_assert(emu != NULL && card != NULL, return -EINVAL);
+       if (snd_BUG_ON(!emu || !card))
+               return -EINVAL;
 
        spin_lock_init(&emu->control_lock);
 

diff --git a/sound/isa/sb/emu8000_patch.c b/sound/isa/sb/emu8000_patch.c
index 1be16c9700f09cd254117f3a0de9b014997de6f6..c99c6078be3376fa792f8b335e31f57a80a7c221 100644 (file)
--- a/sound/isa/sb/emu8000_patch.c
+++ b/sound/isa/sb/emu8000_patch.c
@@ -156,7 +156,8 @@ snd_emu8000_sample_new(struct snd_emux *rec, struct snd_sf_sample *sp,
        struct snd_emu8000 *emu;
 
        emu = rec->hw;
-       snd_assert(sp != NULL, return -EINVAL);
+       if (snd_BUG_ON(!sp))
+               return -EINVAL;
 
        if (sp->v.size == 0)
                return 0;

diff --git a/sound/isa/sb/sb16_csp.c b/sound/isa/sb/sb16_csp.c
index 35f3d7b16536ee9dfc528c47fd1365575c3023d7..49037d074c719f8e2ef2160b1d8730af1dec2cf6 100644 (file)
--- a/sound/isa/sb/sb16_csp.c
+++ b/sound/isa/sb/sb16_csp.c
@@ -198,7 +198,8 @@ static int snd_sb_csp_ioctl(struct snd_hwdep * hw, struct file *file, unsigned i
        struct snd_sb_csp_start start_info;
        int err;
 
-       snd_assert(p != NULL, return -EINVAL);
+       if (snd_BUG_ON(!p))
+               return -EINVAL;
 
        if (snd_sb_csp_check_version(p))
                return -ENODEV;
@@ -1046,7 +1047,8 @@ static int snd_sb_qsound_build(struct snd_sb_csp * p)
        struct snd_card *card;
        int err;
 
-       snd_assert(p != NULL, return -EINVAL);
+       if (snd_BUG_ON(!p))
+               return -EINVAL;
 
        card = p->chip->card;
        p->qpos_left = p->qpos_right = SNDRV_SB_CSP_QSOUND_MAX_RIGHT / 2;
@@ -1071,7 +1073,8 @@ static void snd_sb_qsound_destroy(struct snd_sb_csp * p)
        struct snd_card *card;
        unsigned long flags;
 
-       snd_assert(p != NULL, return);
+       if (snd_BUG_ON(!p))
+               return;
 
        card = p->chip->card;   
        

diff --git a/sound/isa/sb/sb16_main.c b/sound/isa/sb/sb16_main.c
index f7e8192270ae1796a302b1893f3b18136a1f8bee..2a6cc1cfe945a6f731690c06b97026b1e2ef1d65 100644 (file)
--- a/sound/isa/sb/sb16_main.c
+++ b/sound/isa/sb/sb16_main.c
@@ -669,7 +669,8 @@ static int snd_sb16_capture_close(struct snd_pcm_substream *substream)
 static int snd_sb16_set_dma_mode(struct snd_sb *chip, int what)
 {
        if (chip->dma8 < 0 || chip->dma16 < 0) {
-               snd_assert(what == 0, return -EINVAL);
+               if (snd_BUG_ON(what))
+                       return -EINVAL;
                return 0;
        }
        if (what == 0) {

diff --git a/sound/isa/sb/sb8_main.c b/sound/isa/sb/sb8_main.c
index fe03bb820532beed11afd25dbfe8c67959ead1fa..658d55769c9cd5ff44adf13aee830b455b215f5f 100644 (file)
--- a/sound/isa/sb/sb8_main.c
+++ b/sound/isa/sb/sb8_main.c
@@ -111,7 +111,9 @@ static int snd_sb8_playback_prepare(struct snd_pcm_substream *substream)
        switch (chip->hardware) {
        case SB_HW_PRO:
                if (runtime->channels > 1) {
-                       snd_assert(rate == SB8_RATE(11025) || rate == SB8_RATE(22050), return -EINVAL);
+                       if (snd_BUG_ON(rate != SB8_RATE(11025) &&
+                                      rate != SB8_RATE(22050)))
+                               return -EINVAL;
                        chip->playback_format = SB_DSP_HI_OUTPUT_AUTO;
                        break;
                }
@@ -237,7 +239,9 @@ static int snd_sb8_capture_prepare(struct snd_pcm_substream *substream)
        switch (chip->hardware) {
        case SB_HW_PRO:
                if (runtime->channels > 1) {
-                       snd_assert(rate == SB8_RATE(11025) || rate == SB8_RATE(22050), return -EINVAL);
+                       if (snd_BUG_ON(rate != SB8_RATE(11025) &&
+                                      rate != SB8_RATE(22050)))
+                               return -EINVAL;
                        chip->capture_format = SB_DSP_HI_INPUT_AUTO;
                        break;
                }

diff --git a/sound/isa/sb/sb_common.c b/sound/isa/sb/sb_common.c
index b432d9ae874baba6b52d837b8886eff2dd02fc22..27a65150225168a3f7264c4d6c1c6f8667cc7bfa 100644 (file)
--- a/sound/isa/sb/sb_common.c
+++ b/sound/isa/sb/sb_common.c
@@ -219,7 +219,8 @@ int snd_sbdsp_create(struct snd_card *card,
                .dev_free =     snd_sbdsp_dev_free,
        };
 
-       snd_assert(r_chip != NULL, return -EINVAL);
+       if (snd_BUG_ON(!r_chip))
+               return -EINVAL;
        *r_chip = NULL;
        chip = kzalloc(sizeof(*chip), GFP_KERNEL);
        if (chip == NULL)

diff --git a/sound/isa/sb/sb_mixer.c b/sound/isa/sb/sb_mixer.c
index 73d4572d136bb893da5435ecc97313a52ccb7ba0..406a431af91ec6880d548b39b0f423c9bb01a56b 100644 (file)
--- a/sound/isa/sb/sb_mixer.c
+++ b/sound/isa/sb/sb_mixer.c
@@ -792,7 +792,8 @@ int snd_sbmixer_new(struct snd_sb *chip)
        struct snd_card *card;
        int err;
 
-       snd_assert(chip != NULL && chip->card != NULL, return -EINVAL);
+       if (snd_BUG_ON(!chip || !chip->card))
+               return -EINVAL;
 
        card = chip->card;
 
@@ -925,7 +926,8 @@ static unsigned char als4000_saved_regs[] = {
 static void save_mixer(struct snd_sb *chip, unsigned char *regs, int num_regs)
 {
        unsigned char *val = chip->saved_regs;
-       snd_assert(num_regs <= ARRAY_SIZE(chip->saved_regs), return);
+       if (snd_BUG_ON(num_regs > ARRAY_SIZE(chip->saved_regs)))
+               return;
        for (; num_regs; num_regs--)
                *val++ = snd_sbmixer_read(chip, *regs++);
 }
@@ -933,7 +935,8 @@ static void save_mixer(struct snd_sb *chip, unsigned char *regs, int num_regs)
 static void restore_mixer(struct snd_sb *chip, unsigned char *regs, int num_regs)
 {
        unsigned char *val = chip->saved_regs;
-       snd_assert(num_regs <= ARRAY_SIZE(chip->saved_regs), return);
+       if (snd_BUG_ON(num_regs > ARRAY_SIZE(chip->saved_regs)))
+               return;
        for (; num_regs; num_regs--)
                snd_sbmixer_write(chip, *regs++, *val++);
 }

diff --git a/sound/isa/wavefront/wavefront_fx.c b/sound/isa/wavefront/wavefront_fx.c
index 2efaa7f205aa617f56c64db3e26f3e279db25246..dfc449a2194e9795cb07cec10edf84af66b529ac 100644 (file)
--- a/sound/isa/wavefront/wavefront_fx.c
+++ b/sound/isa/wavefront/wavefront_fx.c
@@ -180,11 +180,11 @@ snd_wavefront_fx_ioctl (struct snd_hwdep *sdev, struct file *file,
        unsigned short *pd;
        int err = 0;
 
-       snd_assert(sdev->card != NULL, return -ENODEV);
-       
        card = sdev->card;
-
-       snd_assert(card->private_data != NULL, return -ENODEV);
+       if (snd_BUG_ON(!card))
+               return -ENODEV;
+       if (snd_BUG_ON(!card->private_data))
+               return -ENODEV;
 
        acard = card->private_data;
        dev = &acard->wavefront;

diff --git a/sound/isa/wavefront/wavefront_midi.c b/sound/isa/wavefront/wavefront_midi.c
index a33384a55b0f6576d1a71320d8f68b33a1c622c4..f14a7c0b69981ea607236b756588f0919bd3e4fe 100644 (file)
--- a/sound/isa/wavefront/wavefront_midi.c
+++ b/sound/isa/wavefront/wavefront_midi.c
@@ -235,8 +235,10 @@ static int snd_wavefront_midi_input_open(struct snd_rawmidi_substream *substream
        snd_wavefront_midi_t *midi;
        snd_wavefront_mpu_id mpu;
 
-       snd_assert(substream != NULL && substream->rmidi != NULL, return -EIO);
-       snd_assert(substream->rmidi->private_data != NULL, return -EIO);
+       if (snd_BUG_ON(!substream || !substream->rmidi))
+               return -ENXIO;
+       if (snd_BUG_ON(!substream->rmidi->private_data))
+               return -ENXIO;
 
        mpu = *((snd_wavefront_mpu_id *) substream->rmidi->private_data);
 
@@ -257,8 +259,10 @@ static int snd_wavefront_midi_output_open(struct snd_rawmidi_substream *substrea
        snd_wavefront_midi_t *midi;
        snd_wavefront_mpu_id mpu;
 
-       snd_assert(substream != NULL && substream->rmidi != NULL, return -EIO);
-       snd_assert(substream->rmidi->private_data != NULL, return -EIO);
+       if (snd_BUG_ON(!substream || !substream->rmidi))
+               return -ENXIO;
+       if (snd_BUG_ON(!substream->rmidi->private_data))
+               return -ENXIO;
 
        mpu = *((snd_wavefront_mpu_id *) substream->rmidi->private_data);
 
@@ -279,8 +283,10 @@ static int snd_wavefront_midi_input_close(struct snd_rawmidi_substream *substrea
        snd_wavefront_midi_t *midi;
        snd_wavefront_mpu_id mpu;
 
-       snd_assert(substream != NULL && substream->rmidi != NULL, return -EIO);
-       snd_assert(substream->rmidi->private_data != NULL, return -EIO);
+       if (snd_BUG_ON(!substream || !substream->rmidi))
+               return -ENXIO;
+       if (snd_BUG_ON(!substream->rmidi->private_data))
+               return -ENXIO;
 
        mpu = *((snd_wavefront_mpu_id *) substream->rmidi->private_data);
 
@@ -300,8 +306,10 @@ static int snd_wavefront_midi_output_close(struct snd_rawmidi_substream *substre
        snd_wavefront_midi_t *midi;
        snd_wavefront_mpu_id mpu;
 
-       snd_assert(substream != NULL && substream->rmidi != NULL, return -EIO);
-       snd_assert(substream->rmidi->private_data != NULL, return -EIO);
+       if (snd_BUG_ON(!substream || !substream->rmidi))
+               return -ENXIO;
+       if (snd_BUG_ON(!substream->rmidi->private_data))
+               return -ENXIO;
 
        mpu = *((snd_wavefront_mpu_id *) substream->rmidi->private_data);
 

diff --git a/sound/isa/wavefront/wavefront_synth.c b/sound/isa/wavefront/wavefront_synth.c
index 0bb9b92566010875f148106c8423bf04a5b3cff8..4c410820a994affcdc5f3ed448b8ad4e96343e06 100644 (file)
--- a/sound/isa/wavefront/wavefront_synth.c
+++ b/sound/isa/wavefront/wavefront_synth.c
@@ -1648,9 +1648,10 @@ snd_wavefront_synth_ioctl (struct snd_hwdep *hw, struct file *file,
 
        card = (struct snd_card *) hw->card;
 
-       snd_assert(card != NULL, return -ENODEV);
-
-       snd_assert(card->private_data != NULL, return -ENODEV);
+       if (snd_BUG_ON(!card))
+               return -ENODEV;
+       if (snd_BUG_ON(!card->private_data))
+               return -ENODEV;
 
        acard = card->private_data;
        dev = &acard->wavefront;

diff --git a/sound/isa/wss/wss_lib.c b/sound/isa/wss/wss_lib.c
index 6b7a0fc6f71dccbe8ce15580a35a5068708a22c1..c5beec65936dfbad4a70223b4d4f4ab3c04b1d13 100644 (file)
--- a/sound/isa/wss/wss_lib.c
+++ b/sound/isa/wss/wss_lib.c
@@ -1946,7 +1946,8 @@ static int snd_wss_info_mux(struct snd_kcontrol *kcontrol,
        char **ptexts = texts;
        struct snd_wss *chip = snd_kcontrol_chip(kcontrol);
 
-       snd_assert(chip->card != NULL, return -EINVAL);
+       if (snd_BUG_ON(!chip->card))
+               return -EINVAL;
        uinfo->type = SNDRV_CTL_ELEM_TYPE_ENUMERATED;
        uinfo->count = 2;
        uinfo->value.enumerated.items = 4;
@@ -2262,7 +2263,8 @@ int snd_wss_mixer(struct snd_wss *chip)
        unsigned int idx;
        int err;
 
-       snd_assert(chip != NULL && chip->pcm != NULL, return -EINVAL);
+       if (snd_BUG_ON(!chip || !chip->pcm))
+               return -EINVAL;
 
        card = chip->card;