]> pilppa.com Git - linux-2.6-omap-h63xx.git/commitdiff
[PATCH] fbdev: Initialize var structure in calc_mode_timings
authorAntonino A. Daplas <adaplas@gmail.com>
Fri, 9 Sep 2005 20:10:02 +0000 (13:10 -0700)
committerLinus Torvalds <torvalds@g5.osdl.org>
Fri, 9 Sep 2005 21:03:40 +0000 (14:03 -0700)
The var structure in calc_mode_timings is not properly initialized (zero set)
which leads to undefined behavior when it is passed to fb_get_mode().

Signed-off-by: Antonino Daplas <adaplas@pol.net>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
drivers/video/fbmon.c

index 791bec3d672af47d999e798baf87760cc4b17188..713226cdf3c6b7a7ce0a247447d1909d05e57396 100644 (file)
@@ -314,11 +314,13 @@ static int edid_is_monitor_block(unsigned char *block)
                return 0;
 }
 
-static void calc_mode_timings(int xres, int yres, int refresh, struct fb_videomode *mode)
+static void calc_mode_timings(int xres, int yres, int refresh,
+                             struct fb_videomode *mode)
 {
        struct fb_var_screeninfo var;
        struct fb_info info;
        
+       memset(&var, 0, sizeof(struct fb_var_screeninfo));
        var.xres = xres;
        var.yres = yres;
        fb_get_mode(FB_VSYNCTIMINGS | FB_IGNOREMON,