]> pilppa.com Git - linux-2.6-omap-h63xx.git/commitdiff
fbdev: fb_create_modedb() non-static `int first = 1;'
authorGeert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>
Tue, 16 Oct 2007 08:28:52 +0000 (01:28 -0700)
committerLinus Torvalds <torvalds@woody.linux-foundation.org>
Tue, 16 Oct 2007 16:43:15 +0000 (09:43 -0700)
Looking at the code flow, `int first' in fb_create_modedb() should be static.

[adaplas]
Better for 'int first' to be moved outside the loop.

[akpm@linux-foundation.org: kill stray semicolon]
Signed-off-by: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>
Signed-off-by: Antonino Daplas <adaplas@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/video/fbmon.c

index 438b9411905c58e1536578b266a919e1df152a6d..4ba9c08944161043fb1c9a13a3e4a0b5652dc5c7 100644 (file)
@@ -591,7 +591,7 @@ static struct fb_videomode *fb_create_modedb(unsigned char *edid, int *dbsize)
 {
        struct fb_videomode *mode, *m;
        unsigned char *block;
-       int num = 0, i;
+       int num = 0, i, first = 1;
 
        mode = kzalloc(50 * sizeof(struct fb_videomode), GFP_KERNEL);
        if (mode == NULL)
@@ -608,8 +608,6 @@ static struct fb_videomode *fb_create_modedb(unsigned char *edid, int *dbsize)
        DPRINTK("   Detailed Timings\n");
        block = edid + DETAILED_TIMING_DESCRIPTIONS_START;
        for (i = 0; i < 4; i++, block+= DETAILED_TIMING_DESCRIPTION_SIZE) {
-               int first = 1;
-
                if (!(block[0] == 0x00 && block[1] == 0x00)) {
                        get_detailed_timing(block, &mode[num]);
                        if (first) {