]> pilppa.com Git - linux-2.6-omap-h63xx.git/commitdiff
fsl_usb2_udc: Add a wmb before priming endpoint.
authorWill Newton <will.newton@gmail.com>
Tue, 12 Aug 2008 14:39:16 +0000 (15:39 +0100)
committerGreg Kroah-Hartman <gregkh@suse.de>
Fri, 17 Oct 2008 21:41:07 +0000 (14:41 -0700)
Add a wmb to fsl_queue_td before priming the endpoint. This ensures that the
modifications to the QH are seen by the hardware.

Added comment as suggested by Felipe Balbi.

Signed-off-by: Will Newton <will.newton@gmail.com>
Acked-by: Li Yang <leoli@freescale.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/usb/gadget/fsl_usb2_udc.c

index 6f6272031344a34da80cdc86035aea5ef9d034fb..0492441bc0ba80ee77aad62261c771687bd51c69 100644 (file)
@@ -643,6 +643,9 @@ static void fsl_queue_td(struct fsl_ep *ep, struct fsl_req *req)
                        | EP_QUEUE_HEAD_STATUS_HALT));
        dQH->size_ioc_int_sts &= temp;
 
+       /* Ensure that updates to the QH will occure before priming. */
+       wmb();
+
        /* Prime endpoint by writing 1 to ENDPTPRIME */
        temp = ep_is_in(ep)
                ? (1 << (ep_index(ep) + 16))