]> pilppa.com Git - linux-2.6-omap-h63xx.git/commitdiff
V4L/DVB (6215): Bugfix for saa6588.c, add forgotten spin_lock_init()
authorHans-Jürgen Koch <hjk@linutronix.de>
Wed, 12 Sep 2007 19:20:43 +0000 (16:20 -0300)
committerMauro Carvalho Chehab <mchehab@infradead.org>
Wed, 10 Oct 2007 01:14:35 +0000 (22:14 -0300)
There's a serious bug in saa6588.c, it uses a non-initialized spin_lock.
Funny thing is that it works fine with bttv, but completly freezes the
machine if e.g. saa7134 is loaded.

Thanks to Derek Philip for reporting this bug on the rdsd-devel list.

This patch adds the missing spin_lock_init().

Signed-off-by: Hans J. Koch <hjk@linutronix.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
drivers/media/video/saa6588.c

index 92eabf88a09b72e336ce55ea1b4f4901b432ce18..72e344a12c798e86a5ca06db54c4c7a8059e423b 100644 (file)
@@ -406,6 +406,7 @@ static int saa6588_attach(struct i2c_adapter *adap, int addr, int kind)
                kfree(s);
                return -ENOMEM;
        }
+       spin_lock_init(&s->lock);
        s->client = client_template;
        s->block_count = 0;
        s->wr_index = 0;