]> pilppa.com Git - linux-2.6-omap-h63xx.git/commitdiff
[SCSI] zfcp: Fix error handling for blocked unit for send FCP command
authorChristof Schmitt <christof.schmitt@de.ibm.com>
Fri, 18 Apr 2008 10:51:57 +0000 (12:51 +0200)
committerJames Bottomley <James.Bottomley@HansenPartnership.com>
Fri, 18 Apr 2008 16:50:41 +0000 (11:50 -0500)
In the case the unit is blocked, zfcp_unit_get has not been called
yet, so the error handling path should not call zfcp_unit_put.

Signed-off-by: Christof Schmitt <christof.schmitt@de.ibm.com>
Signed-off-by: Martin Peschke <mp3@de.ibm.com>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
drivers/s390/scsi/zfcp_fsf.c

index 3211dcc595435d201095fa6f782de35c729ff2c2..7c3f02816e95c35b8ed6005c9f0c7d7fa2f9fa21 100644 (file)
@@ -3562,8 +3562,8 @@ zfcp_fsf_send_fcp_command_task(struct zfcp_adapter *adapter,
  send_failed:
  no_fit:
  failed_scsi_cmnd:
- unit_blocked:
        zfcp_unit_put(unit);
+ unit_blocked:
        zfcp_fsf_req_free(fsf_req);
        fsf_req = NULL;
        scsi_cmnd->host_scribble = NULL;