]> pilppa.com Git - linux-2.6-omap-h63xx.git/commitdiff
x86: io-apic - do not use KERN_DEBUG marker too much, fix
authorCyrill Gorcunov <gorcunov@gmail.com>
Sat, 13 Sep 2008 09:11:16 +0000 (13:11 +0400)
committerIngo Molnar <mingo@elte.hu>
Thu, 16 Oct 2008 14:53:10 +0000 (16:53 +0200)
Yinghai Lu reported:

| >  0 add_pin_to_irq: irq 15 --> apic 0 pin 15
| > IOAPIC[0]: Set routing entry (8-15 -> 0x3f -> IRQ 15 Mode:0 Active:0)
| >  8-16 8-17 8-18 8-19 8-20 8-21 8-22 8-23 (apicid-pin) not connected
| >  9-0 9-1 9-2 9-3 9-4 9-5 9-6 9-7 9-8 9-9 9-10 9-11 9-12 9-13 9-14 9-15
| > 9-16 9-17 9-18 9-19 9-20 9-21 9-22 9-23 (apicid-pin) not connected
| >
|
| only first one not connected at first, and ...

here is a quick fix for this.

Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
arch/x86/kernel/io_apic.c

index ac47384724e36255594542fa1c6b2a4d94ddc4d9..6ce5873a406c43576f14aba38a3df12ce31954bc 100644 (file)
@@ -1541,6 +1541,11 @@ static void __init setup_IO_APIC_irqs(void)
                                                pin);
                                continue;
                        }
+                       if (notcon) {
+                               apic_printk(APIC_VERBOSE,
+                                       " (apicid-pin) not connected\n");
+                               notcon = 0;
+                       }
 
                        irq = pin_2_irq(idx, apic, pin);
 #ifdef CONFIG_X86_32
@@ -1552,11 +1557,6 @@ static void __init setup_IO_APIC_irqs(void)
                        setup_IO_APIC_irq(apic, pin, irq,
                                        irq_trigger(idx), irq_polarity(idx));
                }
-               if (notcon) {
-                       apic_printk(APIC_VERBOSE,
-                               " (apicid-pin) not connected\n");
-                       notcon = 0;
-               }
        }
 
        if (notcon)