sysfs: kill unnecessary NULL pointer check in sysfs_release()

In sysfs_release(), sysfs_buffer pointed to by filp->private_data is
guaranteed to exist.  Kill the unnecessary NULL check.  This also
makes the code more consistent with the counterpart in fs/sysfs/bin.c.

Signed-off-by: Tejun Heo <htejun@gmail.com>
Acked-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

diff --git a/fs/sysfs/file.c b/fs/sysfs/file.c
index 73333dc68545ce6086bba84881d43658249572d6..8f1ebd88b9cec02f01e36c1f02d77017578627e8 100644 (file)
--- a/fs/sysfs/file.c
+++ b/fs/sysfs/file.c
@@ -311,11 +311,10 @@ static int sysfs_release(struct inode * inode, struct file * filp)
 {
        struct sysfs_buffer *buffer = filp->private_data;
 
-       if (buffer) {
-               if (buffer->page)
-                       free_page((unsigned long)buffer->page);
-               kfree(buffer);
-       }
+       if (buffer->page)
+               free_page((unsigned long)buffer->page);
+       kfree(buffer);
+
        return 0;
 }