]> pilppa.com Git - linux-2.6-omap-h63xx.git/commitdiff
[JFFS2] Clean up jffs2_alloc_inode() and jffs2_i_init_once()
authorDavid Woodhouse <dwmw2@infradead.org>
Thu, 1 May 2008 11:28:04 +0000 (12:28 +0100)
committerDavid Woodhouse <dwmw2@infradead.org>
Thu, 1 May 2008 11:29:37 +0000 (12:29 +0100)
Ditch a couple of pointless casts from void *, and use the normal
variable name 'f' for jffs2_inode_info pointers -- especially since
it actually shows up in lockdep reports.

Signed-off-by: David Woodhouse <dwmw2@infradead.org>
fs/jffs2/super.c

index f3353df178e707e8072e048e46b23753e5c88d5d..7da69eae49e491267699dcd8ca50535f5af15aed 100644 (file)
@@ -31,11 +31,12 @@ static struct kmem_cache *jffs2_inode_cachep;
 
 static struct inode *jffs2_alloc_inode(struct super_block *sb)
 {
-       struct jffs2_inode_info *ei;
-       ei = (struct jffs2_inode_info *)kmem_cache_alloc(jffs2_inode_cachep, GFP_KERNEL);
-       if (!ei)
+       struct jffs2_inode_info *f;
+
+       f = kmem_cache_alloc(jffs2_inode_cachep, GFP_KERNEL);
+       if (!f)
                return NULL;
-       return &ei->vfs_inode;
+       return &f->vfs_inode;
 }
 
 static void jffs2_destroy_inode(struct inode *inode)
@@ -45,10 +46,10 @@ static void jffs2_destroy_inode(struct inode *inode)
 
 static void jffs2_i_init_once(struct kmem_cache *cachep, void *foo)
 {
-       struct jffs2_inode_info *ei = (struct jffs2_inode_info *) foo;
+       struct jffs2_inode_info *f = foo;
 
-       mutex_init(&ei->sem);
-       inode_init_once(&ei->vfs_inode);
+       mutex_init(&f->sem);
+       inode_init_once(&f->vfs_inode);
 }
 
 static int jffs2_sync_fs(struct super_block *sb, int wait)