]> pilppa.com Git - linux-2.6-omap-h63xx.git/commitdiff
USB: Remove unneeded void * casts in idmouse.c
authorTobias Klauser <tklauser@distanz.ch>
Wed, 20 Dec 2006 10:42:12 +0000 (11:42 +0100)
committerGreg Kroah-Hartman <gregkh@suse.de>
Wed, 7 Feb 2007 23:44:32 +0000 (15:44 -0800)
The patch removes unneeded void * casts for the following (void *) pointers:
- struct file: private_data

The patch also contains some whitespace and coding style cleanups in the
relevant areas.

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/usb/misc/idmouse.c

index c9418535bef88b520d4a4ee2413da96fbe8129be..15c70bd048c448cf9baa5b4b6d969d57f43cb611 100644 (file)
@@ -269,7 +269,7 @@ static int idmouse_release(struct inode *inode, struct file *file)
        /* prevent a race condition with open() */
        mutex_lock(&disconnect_mutex);
 
-       dev = (struct usb_idmouse *) file->private_data;
+       dev = file->private_data;
 
        if (dev == NULL) {
                mutex_unlock(&disconnect_mutex);
@@ -304,17 +304,15 @@ static int idmouse_release(struct inode *inode, struct file *file)
 static ssize_t idmouse_read(struct file *file, char __user *buffer, size_t count,
                                loff_t * ppos)
 {
-       struct usb_idmouse *dev;
+       struct usb_idmouse *dev = file->private_data;
        int result;
 
-       dev = (struct usb_idmouse *) file->private_data;
-
        /* lock this object */
-       down (&dev->sem);
+       down(&dev->sem);
 
        /* verify that the device wasn't unplugged */
        if (!dev->present) {
-               up (&dev->sem);
+               up(&dev->sem);
                return -ENODEV;
        }