]> pilppa.com Git - linux-2.6-omap-h63xx.git/commitdiff
x86: early_printk.c trivial sparse fixes
authorHarvey Harrison <harvey.harrison@gmail.com>
Mon, 18 Aug 2008 23:56:29 +0000 (16:56 -0700)
committerIngo Molnar <mingo@elte.hu>
Tue, 19 Aug 2008 00:14:29 +0000 (02:14 +0200)
arch/x86/kernel/early_printk.c:404:13: warning: incorrect type in assignment (different base types)
arch/x86/kernel/early_printk.c:404:13:    expected restricted __le16 [assigned] [usertype] wValue
arch/x86/kernel/early_printk.c:404:13:    got int [signed] value
arch/x86/kernel/early_printk.c:405:13: warning: incorrect type in assignment (different base types)
arch/x86/kernel/early_printk.c:405:13:    expected restricted __le16 [assigned] [usertype] wIndex
arch/x86/kernel/early_printk.c:405:13:    got int [signed] index
arch/x86/kernel/early_printk.c:406:14: warning: incorrect type in assignment (different base types)
arch/x86/kernel/early_printk.c:406:14:    expected restricted __le16 [assigned] [usertype] wLength
arch/x86/kernel/early_printk.c:406:14:    got int [signed] size
arch/x86/kernel/early_printk.c:845:16: warning: Using plain integer as NULL pointer
arch/x86/kernel/early_printk.c:992:13: warning: symbol 'enable_debug_console' was not declared. Should it be static?

Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
arch/x86/kernel/early_printk.c

index 28155acf706e8e9b6c4ae80298336f555558bc16..825e9136b026b07984f6722aadd0bc506c37148e 100644 (file)
@@ -401,9 +401,9 @@ static int dbgp_control_msg(unsigned devnum, int requesttype, int request,
        /* Compute the control message */
        req.bRequestType = requesttype;
        req.bRequest = request;
-       req.wValue = value;
-       req.wIndex = index;
-       req.wLength = size;
+       req.wValue = cpu_to_le16(value);
+       req.wIndex = cpu_to_le16(index);
+       req.wLength = cpu_to_le16(size);
 
        pids = DBGP_PID_SET(USB_PID_DATA0, USB_PID_SETUP);
        addr = DBGP_EPADDR(devnum, 0);
@@ -842,7 +842,7 @@ static int __init early_dbgp_init(char *s)
        ret = ehci_setup();
        if (ret < 0) {
                dbgp_printk("ehci_setup failed\n");
-               ehci_debug = 0;
+               ehci_debug = NULL;
 
                return -1;
        }
@@ -989,7 +989,7 @@ static int __init setup_early_printk(char *buf)
        return 0;
 }
 
-void __init enable_debug_console(char *buf)
+static void __init enable_debug_console(char *buf)
 {
 #ifdef DBGP_DEBUG
        struct console *old_early_console = NULL;