]> pilppa.com Git - linux-2.6-omap-h63xx.git/commitdiff
virtio: fix vring_init for 64 bits
authorAnthony Liguori <aliguori@us.ibm.com>
Wed, 7 Nov 2007 05:31:52 +0000 (16:31 +1100)
committerRusty Russell <rusty@rustcorp.com.au>
Mon, 12 Nov 2007 02:55:12 +0000 (13:55 +1100)
This patch fixes a typo in vring_init().  This happens to work today in lguest
because the sizeof(struct vring_desc) is 16 and struct vring contains 3
pointers and an unsigned int so on 32-bit
sizeof(struct vring_desc) == sizeof(struct vring).  However, this is no longer
true on 64-bit where the bug is exposed.

Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
include/linux/virtio_ring.h

index ac69e7bb5a14f5465df654a5d7668cb45a7669f5..5b88d215af50c6176cc9c1632c67166da476a0f4 100644 (file)
@@ -92,8 +92,8 @@ static inline void vring_init(struct vring *vr, unsigned int num, void *p)
 {
        vr->num = num;
        vr->desc = p;
-       vr->avail = p + num*sizeof(struct vring);
-       vr->used = p + (num+1)*(sizeof(struct vring) + sizeof(__u16));
+       vr->avail = p + num*sizeof(struct vring_desc);
+       vr->used = p + (num+1)*(sizeof(struct vring_desc) + sizeof(__u16));
 }
 
 static inline unsigned vring_size(unsigned int num)