]> pilppa.com Git - linux-2.6-omap-h63xx.git/commitdiff
DM9000 initialization fix
authorMike Rapoport <mike@compulab.co.il>
Thu, 18 Oct 2007 07:23:11 +0000 (09:23 +0200)
committerJeff Garzik <jeff@garzik.org>
Sat, 20 Oct 2007 03:00:01 +0000 (23:00 -0400)
DM9000 driver returns success even if it is failed to detect the chip.
Below patch fixes it.

Signed-off-by: Mike Rapoport <mike@compulab.co.il>
 drivers/net/dm9000.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
Signed-off-by: Jeff Garzik <jeff@garzik.org>
drivers/net/dm9000.c

index 27ac010900abd7ffce88ee26973569161606f567..3286d2a0a870568c3cb8f857be65526bfa4a8d20 100644 (file)
@@ -542,7 +542,8 @@ dm9000_probe(struct platform_device *pdev)
 
        if (id_val != DM9000_ID) {
                printk("%s: wrong id: 0x%08x\n", CARDNAME, id_val);
-               goto release;
+               ret = -ENODEV;
+               goto out;
        }
 
        /* from this point we assume that we have found a DM9000 */
@@ -602,8 +603,7 @@ dm9000_probe(struct platform_device *pdev)
        }
        return 0;
 
- release:
- out:
+out:
        printk("%s: not found (%d).\n", CARDNAME, ret);
 
        dm9000_release_board(pdev, db);