]> pilppa.com Git - linux-2.6-omap-h63xx.git/commitdiff
[PATCH] hwmon: Off-by-one error in fscpos driver
authorJean Delvare <khali@linux-fr.org>
Thu, 25 Aug 2005 16:43:37 +0000 (18:43 +0200)
committerLinus Torvalds <torvalds@g5.osdl.org>
Fri, 26 Aug 2005 23:31:46 +0000 (16:31 -0700)
Coverity uncovered an off-by-one error in the fscpos driver, in function
set_temp_reset(). Writing to the temp3_reset sysfs file will lead to an
array overrun, in turn causing an I2C write to a random register of the
FSC Poseidon chip. Additionally, writing to temp1_reset and temp2_reset
will not work as expected. The fix is straightforward.

Signed-off-by: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
drivers/hwmon/fscpos.c

index 270015b626adefcc3fe66cd41fefc2391bb33706..301ae98bd0adb1fca9d0f0e6687a538019439a0b 100644 (file)
@@ -167,7 +167,7 @@ static ssize_t set_temp_reset(struct i2c_client *client, struct fscpos_data
                                "experience to the module author.\n");
 
        /* Supported value: 2 (clears the status) */
-       fscpos_write_value(client, FSCPOS_REG_TEMP_STATE[nr], 2);
+       fscpos_write_value(client, FSCPOS_REG_TEMP_STATE[nr - 1], 2);
        return count;
 }