]> pilppa.com Git - linux-2.6-omap-h63xx.git/commitdiff
PCI: stop leaking 'slot_name' in pci_create_slot
authorAlex Chiang <achiang@hp.com>
Tue, 2 Dec 2008 01:17:21 +0000 (18:17 -0700)
committerJesse Barnes <jbarnes@virtuousgeek.org>
Tue, 9 Dec 2008 22:36:03 +0000 (14:36 -0800)
In pci_create_slot(), the local variable 'slot_name' is allocated by
make_slot_name(), but never freed. We never use it after passing it to
the kobject core, so we should free it upon function exit.

Cc: stable@kernel.org
Signed-off-by: Alex Chiang <achiang@hp.com>
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
drivers/pci/slot.c

index 4dd1c3e157aec6d6c136c02255faed19d46c3dc1..5a8ccb4f604deed50495b61ced5ba403e59e9484 100644 (file)
@@ -253,6 +253,7 @@ placeholder:
                 __func__, pci_domain_nr(parent), parent->number, slot_nr);
 
 out:
+       kfree(slot_name);
        up_write(&pci_bus_sem);
        return slot;
 err: