]> pilppa.com Git - linux-2.6-omap-h63xx.git/commitdiff
sony-laptop: brightness regression fix
authorAlessandro Guido <ag@alessandroguido.name>
Wed, 12 Nov 2008 22:03:28 +0000 (23:03 +0100)
committerLen Brown <len.brown@intel.com>
Wed, 26 Nov 2008 23:12:07 +0000 (18:12 -0500)
After commit 540b8bb9c33935183ceb5bed466a42ad72b2af56:

  sony-laptop: fingers off backlight if video.ko is serving this functionality

I can't set brightness on my sony laptop (nothing in /sys/class/backlight).
dmesg says "sony-laptop: Sony: Brightness ignored, must be controlled by ACPI
video driver".

The function acpi_video_backlight_support returns 0 if we should use the
vendor-specific backlight support, while non-0 if the ACPI generic should
be used. Because of this, the check introduced by the said commit appears
reversed.

Signed-off-by: Alessandro Guido <ag@alessandroguido.name>
Signed-off-by: Len Brown <len.brown@intel.com>
drivers/misc/sony-laptop.c

index 7bcb81002dcfe32dac89391d975ecc03b5d1a8e9..2a613d4f3bd659ff55384350963984a9d9fa542d 100644 (file)
@@ -1038,7 +1038,7 @@ static int sony_nc_add(struct acpi_device *device)
                goto outinput;
        }
 
-       if (!acpi_video_backlight_support()) {
+       if (acpi_video_backlight_support()) {
                printk(KERN_INFO DRV_PFX "Sony: Brightness ignored, must be "
                       "controlled by ACPI video driver\n");
        } else if (ACPI_SUCCESS(acpi_get_handle(sony_nc_acpi_handle, "GBRT",