]> pilppa.com Git - linux-2.6-omap-h63xx.git/commitdiff
[ARM] 5203/1: i2c-pxa: fix scheduling while atomic in i2c_pxa_abort()
authorDmitry Baryshkov <dbaryshkov@gmail.com>
Mon, 18 Aug 2008 13:38:48 +0000 (14:38 +0100)
committerRussell King <rmk+kernel@arm.linux.org.uk>
Tue, 9 Sep 2008 15:32:51 +0000 (16:32 +0100)
i2c_pxa_abort can be called from the atomic context.
Change it to use mdelay and counted loop.

Signed-off-by: Dmitry Baryshkov <dbaryshkov@gmail.com>
Acked-by: Eric Miao <eric.miao@marvell.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
drivers/i2c/busses/i2c-pxa.c

index 5d5fbc518b7b37a6c65fdde01119fe4ac7766734..57fbffd1ccc0def139b687621815fcc214fdfe08 100644 (file)
@@ -189,14 +189,14 @@ static inline int i2c_pxa_is_slavemode(struct pxa_i2c *i2c)
 
 static void i2c_pxa_abort(struct pxa_i2c *i2c)
 {
-       unsigned long timeout = jiffies + HZ/4;
+       int i = 250;
 
        if (i2c_pxa_is_slavemode(i2c)) {
                dev_dbg(&i2c->adap.dev, "%s: called in slave mode\n", __func__);
                return;
        }
 
-       while (time_before(jiffies, timeout) && (readl(_IBMR(i2c)) & 0x1) == 0) {
+       while ((i > 0) && (readl(_IBMR(i2c)) & 0x1) == 0) {
                unsigned long icr = readl(_ICR(i2c));
 
                icr &= ~ICR_START;
@@ -206,7 +206,8 @@ static void i2c_pxa_abort(struct pxa_i2c *i2c)
 
                show_state(i2c);
 
-               msleep(1);
+               mdelay(1);
+               i --;
        }
 
        writel(readl(_ICR(i2c)) & ~(ICR_MA | ICR_START | ICR_STOP),