]> pilppa.com Git - linux-2.6-omap-h63xx.git/commitdiff
[PATCH] libata: add NCQ blacklist entries from Silicon Image Windows driver (v2)
authorRobert Hancock <hancockr@shaw.ca>
Tue, 3 Apr 2007 04:05:29 +0000 (22:05 -0600)
committerLinus Torvalds <torvalds@woody.linux-foundation.org>
Wed, 4 Apr 2007 15:40:17 +0000 (08:40 -0700)
This adds some NCQ blacklist entries taken from the Silicon Image 3124/3132
Windows driver .inf files. There are some confirming reports of problems
with these drives under Linux (for example http://lkml.org/lkml/2007/3/4/178)
so let's disable NCQ on these drives.

 [ I'm personally starting to wonder whether we shouldn't disable NCQ by
   default, and perhaps have a white-list. There seems to be a *lot* of
   drives that do this wrong..   - Linus ]

Signed-off-by: Robert Hancock <hancockr@shaw.ca>
Acked-by: Tejun Heo <htejun@gmail.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/ata/libata-core.c

index ddb3909d7288bcb4f5074c3433a931371aa7ef38..87b47bd3182f9b3b234af2d9b3c7d6ce2a861281 100644 (file)
@@ -3363,6 +3363,11 @@ static const struct ata_blacklist_entry ata_device_blacklist [] = {
        { "Maxtor 6L250S0",     "BANC1G10",     ATA_HORKAGE_NONCQ },
        /* NCQ hard hangs device under heavier load, needs hard power cycle */
        { "Maxtor 6B250S0",     "BANC1B70",     ATA_HORKAGE_NONCQ },
+       /* Blacklist entries taken from Silicon Image 3124/3132
+          Windows driver .inf file - also several Linux problem reports */
+       { "HTS541060G9SA00",    "MB3OC60D",     ATA_HORKAGE_NONCQ, },
+       { "HTS541080G9SA00",    "MB4OC60D",     ATA_HORKAGE_NONCQ, },
+       { "HTS541010G9SA00",    "MBZOC60D",     ATA_HORKAGE_NONCQ, },
 
        /* Devices with NCQ limits */