]> pilppa.com Git - linux-2.6-omap-h63xx.git/commitdiff
sched: nominate preferred wakeup cpu, fix
authorVaidyanathan Srinivasan <svaidy@linux.vnet.ibm.com>
Sat, 20 Dec 2008 04:36:38 +0000 (10:06 +0530)
committerIngo Molnar <mingo@elte.hu>
Tue, 23 Dec 2008 21:37:29 +0000 (22:37 +0100)
Andrew Morton reported:

> kernel/sched.c: In function 'schedule':
> kernel/sched.c:3679: warning: 'active_balance' may be used uninitialized in this function
>
> This warning is correct - the code is buggy.

In sched.c load_balance_newidle, there's real potential use of
uninitialised variable - fix it.

Signed-off-by: Vaidyanathan Srinivasan <svaidy@linux.vnet.ibm.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
kernel/sched.c

index ae5ca3f9e776958a611e8e3be1adb85a9bd3441d..756d981d91a40e0e80239ebca62355c62db06d78 100644 (file)
@@ -3670,7 +3670,7 @@ redo:
        }
 
        if (!ld_moved) {
-               int active_balance;
+               int active_balance = 0;
 
                schedstat_inc(sd, lb_failed[CPU_NEWLY_IDLE]);
                if (!sd_idle && sd->flags & SD_SHARE_CPUPOWER &&