]> pilppa.com Git - linux-2.6-omap-h63xx.git/commitdiff
[S390] qdio: Unrecognized inbound traffic if many FCP devices are online
authorUrsula Braun <braunu@de.ibm.com>
Thu, 17 Apr 2008 05:46:03 +0000 (07:46 +0200)
committerHeiko Carstens <heiko.carstens@de.ibm.com>
Thu, 17 Apr 2008 05:46:58 +0000 (07:46 +0200)
Problem:
Usually every FCP device has its own indicator field the adapter
uses to signal outstanding work. Once a certain limit of devices
is reached, a common indicator field is used. In certain scenarios
qdio resets this common indicator field, but handles only part of
the FCP-devices sharing the common indicator field. Thus inbound
traffic on the non-processed shared FCP-devices is not recognized
immediately.

Solution:
Make sure common indicator field is reset only, if all FCP-devices
sharing the indicator are processed.

Signed-off-by: Ursula Braun <braunu@de.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
drivers/s390/cio/qdio.c

index 2b5bfb7c69e5c81d6d8ab74c6fd011dcb6fad7bb..b1d18aa471c9aee4b4e49fc609118151692bd766 100644 (file)
@@ -1399,7 +1399,7 @@ __tiqdio_inbound_processing(struct qdio_q *q, int spare_ind_was_set)
         * q->dev_st_chg_ind is the indicator, be it shared or not.
         * only clear it, if indicator is non-shared
         */
-       if (!spare_ind_was_set)
+       if (q->dev_st_chg_ind != &spare_indicator)
                tiqdio_clear_summary_bit((__u32*)q->dev_st_chg_ind);
 
        if (q->hydra_gives_outbound_pcis) {