]> pilppa.com Git - linux-2.6-omap-h63xx.git/commitdiff
[PATCH] powerpc: Fix call to ibm,client-architecture-support
authorBenjamin Herrenschmidt <benh@kernel.crashing.org>
Wed, 7 Jun 2006 02:01:32 +0000 (12:01 +1000)
committerPaul Mackerras <paulus@samba.org>
Fri, 9 Jun 2006 03:05:51 +0000 (13:05 +1000)
The code in prom_init.c calling the firmware
ibm,client-architecture-support method on pSeries has a bug where it
fails to properly pass the instance handle of the firmware object when
trying to call a method. Result ranges from the call doing nothing to
the firmware crashing. (Found by Segher, thanks !)

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Segher Boessenkool <segher@kernel.crashing.org>
Signed-off-by: Paul Mackerras <paulus@samba.org>
arch/powerpc/kernel/prom_init.c

index 41e9ab40cd543f3f0b7b320384c993a121c7b777..f393a3867430c6aa2b8d6c83ead0af594ad5983d 100644 (file)
@@ -822,6 +822,7 @@ static void __init prom_send_capabilities(void)
                /* try calling the ibm,client-architecture-support method */
                if (call_prom_ret("call-method", 3, 2, &ret,
                                  ADDR("ibm,client-architecture-support"),
+                                 root,
                                  ADDR(ibm_architecture_vec)) == 0) {
                        /* the call exists... */
                        if (ret)