]> pilppa.com Git - linux-2.6-omap-h63xx.git/commitdiff
knfsd: nfsd4: fix NFSv4 filehandle size units confusion
authorJ. Bruce Fields <bfields@fieldses.org>
Tue, 17 Jul 2007 11:04:35 +0000 (04:04 -0700)
committerLinus Torvalds <torvalds@woody.linux-foundation.org>
Tue, 17 Jul 2007 17:23:07 +0000 (10:23 -0700)
NFS4_FHSIZE is measured in bytes, not 4-byte words, so much more space than
necessary is being allocated for struct nfs4_cb_recall.

I should have wondered why this structure was so much larger than it needed to
be!

Signed-off-by: "J. Bruce Fields" <bfields@citi.umich.edu>
Signed-off-by: Neil Brown <neilb@suse.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
include/linux/nfsd/state.h

index ab5c236bd9a7c9421eea4652c734ddccd97b3084..732de9cad4a8db0dd4998d806861e51de62ef840 100644 (file)
@@ -67,7 +67,7 @@ struct nfs4_cb_recall {
        int                     cbr_trunc;
        stateid_t               cbr_stateid;
        u32                     cbr_fhlen;
-       u32                     cbr_fhval[NFS4_FHSIZE];
+       char                    cbr_fhval[NFS4_FHSIZE];
        struct nfs4_delegation  *cbr_dp;
 };